keith submitted this change.

View Change

Approvals: keith: Looks good to me, approved Jenkins Builder: Verified
Turn off secure_delete in sqlite

libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten
with zeros on DELETE. We don't needs this extra overhead.

Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/libmsc/db.c b/src/libmsc/db.c
index 0237716..d12f04c 100644
--- a/src/libmsc/db.c
+++ b/src/libmsc/db.c
@@ -569,6 +569,13 @@
/* non-fatal */
}

+ rc = sqlite3_exec(g_dbc->db, "PRAGMA secure_delete=0;", 0, 0, &err_msg);
+ if (rc != SQLITE_OK) {
+ LOGP(DDB, LOGL_ERROR, "Unable to disable SECURE_DELETE: %s\n", err_msg);
+ sqlite3_free(err_msg);
+ /* non-fatal */
+ }
+
return 0;
}


To view, visit change 28341. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: keith <keith@rhizomatica.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged