dexter has uploaded this change for review.
eim_cfg: rename parameter "Style"
The function gen_eim_configuration_data has a parameter "Style".
This parameter sets which format the generated eIM configuration
should have. Let's call this parameter "Format", which describes
better what it is for. Let's also put a comment that explains
how the function works.
Related: SYS#8287
Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21
---
M src/eim_cfg.erl
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/36/43936/1
diff --git a/src/eim_cfg.erl b/src/eim_cfg.erl
index d026eee..dc2adac 100644
--- a/src/eim_cfg.erl
+++ b/src/eim_cfg.erl
@@ -9,7 +9,10 @@
-include_lib("public_key/include/public_key.hrl").
-export([gen_eim_configuration_data/1]).
-gen_eim_configuration_data(Style) ->
+% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC,
+% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data
+% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData
+gen_eim_configuration_data(Format) ->
{ok, EimId} = application:get_env(onomondo_eim, eim_id),
{ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn),
{ok, EimCertPath} = utils:get_env_priv_file_path(onomondo_eim, eim_cert),
@@ -58,7 +61,7 @@
AddInitialEimRequest = #{eimConfigurationDataList => EimConfigurationDataList},
Encoded =
- case Style of
+ case Format of
request ->
% Formatted as AddInitialEimRequest
{ok, Asn1Encoded} = 'SGP32Definitions':encode(
To view, visit change 43936. To unsubscribe, or for help writing mail filters, visit settings.