Attention is currently required from: pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 13: item as just byte, and by leveraging bytearray.translate, we can sped

    sped -> speed up?

    Acknowledged

• File src/target/trx_toolkit/data_msg.py:

  • Patch Set #1, Line 71: self.burst = burst # bytes|bytearray for ubit, array[b] for sbit, array[B] for usbit

    I don't really understand what you mean with this comment here.

    this comment says that the type of self.burst is either bytes or bytearray for unpacked bits, array with typecode='b' for signed soft-bits, and array with typecode='B' for unsigned soft-bits.

  • Patch Set #1, Line 134: def usbit2sbit(bits): # array[B] -> array[b]

    sou one cannot declare a param type for an array as done previously by List?

    seems no: https://stackoverflow.com/questions/69200339/type-hinting-an-array . But I do not use typehints with python beside the very basic cases, so might be missing something.

  • Patch Set #1, Line 672: burst = array('B', burst)

    I wonder whether we'll probably want to have all this encapsulated into eg. SBits, UBits, etc. […]

    Maybe. My primary goal for now was/is to study the system, so I did not pushed hard with optimizing/refactoring things.

To view, visit change 39536. To unsubscribe, or for help writing mail filters, visit settings.