Attention is currently required from: msuraev.

View Change

2 comments:

• File src/host/layer23/include/osmocom/bb/common/ms.h:

  • Patch Set #2, Line 106: enum gsm_chan_t chan_t, const char *name);

    using chan_t for the name of the variable is confusing, it looks like you are passing a type. even gerrit is confused with colors.

• File src/host/layer23/src/common/ms.c:

  • Patch Set #2, Line 50: lapdm_channel_init3(&ms->lapdm_channel, LAPDM_MODE_MS, t200_ms_dcch, t200_ms_acch, chan_t, name);

    if these are to be set to some other value then they will most probably be set by the VTY after the object has been created, so I don't really see the point in having those params passed in the constructor, but rather having an API to set/update them.
    So I'd keep 1 ms_alloc() containing defaults and then add an extra API to set it after the MS is allocated.

To view, visit change 31664. To unsubscribe, or for help writing mail filters, visit settings.