osmith submitted this change.

View Change

testenv: run requirements check before cfg init

When parsing testenv.cfg files, the titan_min version gets compared with
the installed titan version. This fails with a python trace if titan is
not installed. Catch this earlier by running the requirements check
first, which ensures ttcn3_compiler is avaiable or gives a helpful error
message:

  [testenv] Missing program: ttcn3_compiler
  [testenv]   Install eclipse-titan, e.g. from osmocom:latest:
  [testenv]   https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages

Fixes: 18eef740 ("testenv: support using multiple titan versions")
Change-Id: I09ed7af5b236aeffd910d7c0a1a0b63a78631ade
---
M _testenv/testenv.py
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_testenv/testenv.py b/_testenv/testenv.py
index 2aac11e..ebc625e 100755
--- a/_testenv/testenv.py
+++ b/_testenv/testenv.py
@@ -29,12 +29,12 @@
 
 
 def run():
+    testenv.requirements.check()
     testenv.testenv_cfg.init()
 
     if not testenv.args.binary_repo:
         testenv.osmo_dev.check_init_needed()
 
-    testenv.requirements.check()
     testenv.podman_install.init()
     testenv.cmd.init_env()
     testenv.testdir.init()

To view, visit change 40719. To unsubscribe, or for help writing mail filters, visit settings.