Attention is currently required from: pespin.
10 comments:
File include/osmocom/sgsn/debug.h:
Patch Set #16, Line 31: DSGS, /* only as placeholder, SGS isn't used by the SGSN */
I don't get it, if it's not used why adding it here?
because libvlr is using it. I improved the comment.
File src/sgsn/gprs_gmm.c:
Remove whitespace into cosmetic commit
TODO: cosmetic
Patch Set #16, Line 742: /* FIXME: the VLR should check the auth and not here a second time! */
what about all these FIXMEs?
Because I noticed issues and problems with the code and might not fix it, because it gets more and more into a single commit.
The rework is working much better than the current state.
move into cosmetic commit
Patch Set #16, Line 1092: rc = gprs_gmm_parse_att_req(msg, &req);
Looks like addition of this parsing functin could be done easily in a preparation patch...
Done
Patch Set #16, Line 1735: if (TLVP_PRES_LEN(&req.tlv, GSM48_IE_GMM_PDP_CTX_STATUS, 2)) {
This line could have been easily a separate preparation commit...
Done
Patch Set #16, Line 2106: rc = gsm48_rx_gmm_det_accept(mmctx, msg);
The change to a function could have been done in a previous separate commit...
not completely. but did so far as possible
Patch Set #16, Line 2327: static int vlr_tx_auth_req_cb(void *ref, struct vlr_auth_tuple *at, bool send_autn)
I think it makes sense to have all this VLR code in a separate file, there's already too much conten […]
But the libvlr is very connected to the GMM layer. If we move it, I would like to have the discussion in a separate commit.
Patch Set #16, Line 2577: int gmm_vlr_init(struct sgsn_instance *sgi)
This is not really related to a given GMM session, but global one, so it totally makes sense to move […]
I would like to keep it as it is atm.
I'm happy to review the refactoring of this. But it is related to libvlr and
To view, visit change 39562. To unsubscribe, or for help writing mail filters, visit settings.