pespin has uploaded this change for review.

View Change

m3ua: Fix fsm dispatch failure not generating tx ERR msg to peer

Recent commit reworked those code paths to return an error type instead
of an err message, but wrongly left the negative error of
osmo_fsm_inst_dispatch() code path as is, without converting it to a
positive m3ua error code value, which ended up in an ERR msg not being
generated.

Fixes: 82c1d2c8c6699349258869bce690293b590a6b0d
Change-Id: I16042c97453854c78e55bfe6bd6925506eae82c5
---
M src/m3ua.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/71/39771/1

diff --git a/src/m3ua.c b/src/m3ua.c
index 39c799e..04ee7c5 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -734,6 +734,8 @@
 
 	/* deliver that event to the ASP FSM */
 	rc = osmo_fsm_inst_dispatch(asp->fi, event, xua);
+	if (rc < 0)
+		rc = M3UA_ERR_UNEXPECTED_MSG;
 ret_free:
 	xua_msg_free(xua);
 	return rc;

To view, visit change 39771. To unsubscribe, or for help writing mail filters, visit settings.