Attention is currently required from: arehbein, daniel, dexter, fixeria.

View Change

1 comment:

• File include/osmocom/netif/ipa.h:

  • Patch Set #2, Line 26: #warning "OSMO_IPA_MSGB_CB breaks the strict aliasing rule. Don't use unless -fno-strict-aliasing flag is enabled!"

    where are you seeing this problem? TBH I don't envision much of a problem here since we are accessing bytes (uint8_t) in a packed struct.

    You could try a change like this instead:

    struct osmo_ipa_msgb_cb {
            union {
             	unsigned long cb; /* strict aliasing compat */
            	struct {
             	     uint8_t proto;
                         uint8_t proto_ext;
    	       } __attribute__ ((packed));
            };
    } __attribute__ ((packed));

    
    Or:
    union osmo_ipa_msgb_cb {
            unsigned long cb; /* strict aliasing compat */
            struct {
                   uint8_t proto;
                   uint8_t proto_ext;
    	} __attribute__ ((packed));
    };

To view, visit change 34445. To unsubscribe, or for help writing mail filters, visit settings.