Attention is currently required from: arehbein, fixeria, laforge, neels.
7 comments:
File include/osmocom/bsc/bts.h:
Patch Set #12, Line 323: GSM_BTS_TDEF_ID_COUNTDOWN_VALUE
as alluded to above, I was told it'd be good to use positive values for anything coming from the spe […]
Not "anything coming from the specs", but counters/timers explicitly specified with a given T123 or N123 naming.
Hence, since Countdown value is not aexplicitly defined as a T... or N... it must be done as negative (X...).
File src/osmo-bsc/bsc_init.c:
Patch Set #16, Line 240: bts_gprs_timer_groups_init(bts);
(as mentioned above:) I have moved it to `gsm_bts_alloc()`; the function description seemed like a b […]
Done
File src/osmo-bsc/bts.c:
Patch Set #17, Line 466: bts_gprs_timer_groups_init(bts);
did you make sure all counters set up here are not used beforehand in this function when initializing stuff? I bet some counter may be, so this should be far above.
File src/osmo-bsc/bts_init.c:
(this reply is older, hadn't yet published it...) […]
Done
File src/osmo-bsc/bts_init.c:
Patch Set #17, Line 57: .desc = "\"In the extended uplink TBF mode, the uplink TBF may be maintained during temporary inactive periods, "
"Keep uplink TBF alive during inactive periods where the mobile station has no RLC information to transmit (3GPP TS 44.060 Version 6.14.0)"
Patch Set #17, Line 61: .desc = "A delayed release of the downlink TBF is when the release of the downlink TBF is delayed following the transmission of a final data block, "
"Delay release of downlink TBF after all available data has been transmitted"
File src/osmo-bsc/bts_vty.c:
Patch Set #3, Line 1706: /* TODO (BSSGP timer patch): If argument is one of BSSGP Timers strings, then translate to
what lines are you referring to? This is just a TODO comment for the BSSGP timer patch
aha, I'll rephrase: so if it's a a patch about RLC, why are you adding a TODO about BSSGP timers here?
You can simplify this patch since you are anyway adding them in a follow up patch, it's not something left over "for later".
To view, visit change 31878. To unsubscribe, or for help writing mail filters, visit settings.