Attention is currently required from: pespin.

View Change

2 comments:

• File src/trau/trau_frame.c:

  • Patch Set #1, Line 680: memset(trau_bits, 0, 16);

    did you check if it makes sense that this function expects the trau_bits to be 0 initialized? Eg exi […]

    This memset is not 0-initialization, it is the sync pattern. See the frame structure table in TS 48.060 section 5.3.2: the sync pattern consists of the first 16 bits being all zeros, then a single one. "Regular" data and speech frames have more sync pattern bits, but E-TRAU (or EDATA) frames have a reduced sync pattern. The other encoding functions under `osmo_trau_frame_encode` call `encode_sync16` helper, but because we have to produce the reduced sync pattern here, I am doing it directly.

  • Patch Set #1, Line 681: trau_bits[17] = 1;

    isn't this overwritten by the memcpy below?

    Oops, I was setting the wrong bit - good catch! Fixed in the new patch revision.

To view, visit change 38323. To unsubscribe, or for help writing mail filters, visit settings.