Attention is currently required from: laforge, pespin.
Patch set 2:Code-Review -1
View Change
2 comments:
File src/tbf_ul.cpp:
File src/tbf_ul.cpp:
Patch Set #2, Line 266: If this is the case, simply ignore the block
Don't you need to `return` from here?
You say ignore, but you're simply logging a message and the execution continues?
To view, visit change 33415. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1da9b665b9ed83a644ea798008d456d6298b7460
Gerrit-Change-Number: 33415
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 13:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment