laforge submitted this change.

View Change


Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified
ASCI: Fix uninitialized values in vgcs_fsm.c, found by gcc 13.1.1.20230714

Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49
---
M src/osmo-bsc/vgcs_fsm.c
1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/osmo-bsc/vgcs_fsm.c b/src/osmo-bsc/vgcs_fsm.c
index 6b78933..8969d4f 100644
--- a/src/osmo-bsc/vgcs_fsm.c
+++ b/src/osmo-bsc/vgcs_fsm.c
@@ -539,8 +539,10 @@

/* Create VGCS FSM. */
conn->vgcs_call.fi = osmo_fsm_inst_alloc(&vgcs_call_fsm, conn->network, conn, LOGL_DEBUG, NULL);
- if (!conn->vgcs_call.fi)
+ if (!conn->vgcs_call.fi) {
+ cause = GSM0808_CAUSE_INCORRECT_VALUE;
goto reject;
+ }

/* Init list of cells that are used by the call. */
INIT_LLIST_HEAD(&conn->vgcs_call.chan_list);
@@ -1080,7 +1082,7 @@
};
uint8_t cause;
struct gsm_bts *bts;
- struct gsm_lchan *lchan;
+ struct gsm_lchan *lchan = NULL;
int rc;
int i;


To view, visit change 34029. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49
Gerrit-Change-Number: 34029
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged