fixeria submitted this change.

View Change


Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved
mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()

Found by clang:

gsm48_cc.c:54:6: warning: logical not is only applied to the left
hand side of this comparison [-Wlogical-not-parentheses]
if (!cc->mncc_upqueue.next == 0)
^ ~~

Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858
---
M src/host/layer23/src/mobile/gsm48_cc.c
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c
index 4db1925..43c93fc 100644
--- a/src/host/layer23/src/mobile/gsm48_cc.c
+++ b/src/host/layer23/src/mobile/gsm48_cc.c
@@ -52,7 +52,7 @@

cc->ms = ms;

- if (!cc->mncc_upqueue.next == 0)
+ if (cc->mncc_upqueue.next != NULL)
return 0;

LOGP(DCC, LOGL_INFO, "init Call Control\n");

To view, visit change 30963. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858
Gerrit-Change-Number: 30963
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: merged