Attention is currently required from: jolly, laforge.
Patch set 5:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #5:
what's the outcome of the discussion in here?
IMHO moving all this to a thread is overkill. If at all, I'd improve the situation making the several steps delayed through several main loop calls (FSM?) to avoid longer lockings.
In any case, any time critical operations should be processed in a separate thread with appropiate priority, so I don't think this is a reason to backup the complexity in here just for seldom writes to config files imho.
To view, visit change 37798. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
Gerrit-Change-Number: 37798
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: Hoernchen <ewild@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 10:45:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes