Attention is currently required from: dexter, laforge.

View Change

6 comments:

• File docs/cap-tutorial.rst:

  • Patch Set #7, Line 5: support

    "do support ... support"

  • Patch Set #7, Line 54: "maximum_length_of_data_field_in_command_message": 255

    shouldn't there be an additional indention level?

• File pySim/global_platform/__init__.py:

  • Patch Set #7, Line 868: install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49

    looks like copy paste. Maybe clarify that it's one of the installation params setting the volatile memory quota?

  • Patch Set #7, Line 865:

            install_cap_parser.add_argument('--install-parameters', type=is_hexstr, default='',
                                            help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)')
            install_cap_parser.add_argument('--install-parameters-volatile-memory-quota', type=int, default=None,
                                            help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)')
            install_cap_parser.add_argument('--install-parameters-non-volatile-memory-quota', type=int, default=None,
                                            help='Install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)')
            install_cap_parser.add_argument('--install-parameters-stk', type=is_hexstr, default=None,
      
    

    Like in previous patch, define them as mutually exclusive params?
    https://docs.python.org/3/library/argparse.html#mutual-exclusion.

• File pySim/global_platform/install_param.py:

  • Patch Set #7, Line 20:

    from construct import Optional as COptional
    fr
    

    none of these used?

• File tests/unittests/test_globalplatform.py:

  • Patch Set #7, Line 24: *

    you only need `gen_install_parameters()`, so import it alone?
    Otherwise you're importing everything, including imports of the given module.

To view, visit change 39199. To unsubscribe, or for help writing mail filters, visit settings.