Attention is currently required from: laforge, neels.
1 comment:
Patchset:
I think it makes a lot of sense to keep the patches separate as they are. […]
osmo-trx: See trx_rate_ctr_timerfd_cb() and CommonLibs/trx_rate_ctr.cpp in general.
See also dispatch_trx_rate_ctr_change().
osmo-trx is already heavily multithreaded so it's fine doing it that way since it's already complex (it could have been done with an osmo_itq too). For other programs not heavily multithread I'd avoid playing with mutexes and simply rely on message passing integrated in the main loop.
Regarding own thread vs multithread: Anything running under the main loop which blocks the main loop for long periods of time while waiting for some procedure to finish is broken by design, be it 300ms, 500ms, 1s, 3s, 50000s.
Fine if you want to keep it in 2 patches, but I wouldn't merge this one until the other one is ready and can be merged together.
To view, visit change 36385. To unsubscribe, or for help writing mail filters, visit settings.