Attention is currently required from: jolly.

View Change

3 comments:

• Commit Message:

  • Patch Set #3, Line 14: The counter is decrements whenever a CQE is received and handled. This

    is decremeted

• File src/core/osmo_io_uring.c:

  • Patch Set #3, Line 76: unsigned int in_flight;

    "num_in_transit" woulb be better imho, or at least "num_in_flight" to quickly denote it's counter and not a boolean. Maybe also "num_pending_reqs".

  • Patch Set #3, Line 639: ring->in_flight++;

    Sounds like we may want to have a wrapper around io_uring_get_sqe() which increases in_flight if sqe was obtained. I see this same pattern is done in multiple non-related code paths. This way we may avoid skipping the step if we add new code or change it.

To view, visit change 40855. To unsubscribe, or for help writing mail filters, visit settings.