fixeria has uploaded this change for review.
client: fix off-by-one in wrapped pcap stats counter
When a libpcap stats counter (ps_recv/ps_drop/ps_ifdrop) wraps around
UINT_MAX, get_psbl_wrapped_ctr() computed the delta as
(UINT_MAX - old_val) + new_val, omitting the single increment that
takes the counter from UINT_MAX through zero. Add the missing +1 so
the reported delta matches the real number of increments.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7
---
M src/osmo_client_core.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/39/42839/1
diff --git a/src/osmo_client_core.c b/src/osmo_client_core.c
index daa5fd6..dbc2588 100644
--- a/src/osmo_client_core.c
+++ b/src/osmo_client_core.c
@@ -204,6 +204,7 @@
*/
if (old_val > new_val) {
ret = P_CAP_UINT_MAX() - old_val;
+ ret += 1; /* the wrap from UINT_MAX through zero is one increment */
ret += new_val;
return ret;
}
To view, visit change 42839. To unsubscribe, or for help writing mail filters, visit settings.