Attention is currently required from: neels, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    I've been thinking about the main purpose for this: our test suite. […]

    • I agree on the "can be optimized later without ABI breakage"
    • I agree in general it would be better to perform tests of interfaces that our users actually use (stats reporter), but even if that is set to 1s reporting interval, it would mean an (up to) one second latency every time we'd want to check if some counte has incremented as per the tests expectations. We really don't want to slow down our test suite. The CTRL interface has the advantage that it's a request-response interface that gives us the definitive value right now.

• Patchset:

  • Patch Set #4:

    fine with everything except the one issue about splitting the patch

• File src/core/rate_ctr.c:

  • Patch Set #2, Line 284: osmo_quote_str(name, -1));

    this should probably be a separate commit. experience with changes like these shows that we have existing applications breaking with this change, so we might want the capability to test (or revert) that change separately.

To view, visit change 37881. To unsubscribe, or for help writing mail filters, visit settings.