Attention is currently required from: neels, pespin, fixeria, lynxis lazus.

View Change

5 comments:

• Patchset:

  • Patch Set #21:

    do we have any test coverage for this new ramping feature?

• File include/osmocom/bsc/nm_common_fsm.h:

  • Patch Set #16, Line 41: NM_EV_RAMP_GO, /* BTS ramp allow to continue to configure */

    "RAMP" is too generic here, maybe "NM_EV_SETUP_RAMO_GO".

    Done

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #4, Line 3100: bts-setup-ramping-step-interval

    I'm fine with current proposal. […]

    Done

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #15, Line 3121: The amount of BTS while a step interval

    This sentence is somehow wrong, please rephrase.

    Done

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list);

    Maybe I missed the point. […]

    The comment is required as *usually* you ever only use INIT_LLIST_HEADS / LLIST_HEAD_INIT for the "anchor" of the list. Not for elements you add to the list. So this code deviates significantly from established usage patterns of the llist api, hence the suggestion/request for the comment was made. The comment is now added, so all good.

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.