laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
contrib/smpp-ota-tool/cosmetic: use lazy formatting for logging

Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4
Related: OS#6868
---
M contrib/smpp-ota-tool.py
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/smpp-ota-tool.py b/contrib/smpp-ota-tool.py
index f667f84..353f5b5 100755
--- a/contrib/smpp-ota-tool.py
+++ b/contrib/smpp-ota-tool.py
@@ -141,7 +141,7 @@
tuple containing the last response data and the last status word as byte strings
"""

- logger.info("C-APDU sending: %s..." % b2h(apdu))
+ logger.info("C-APDU sending: %s...", b2h(apdu))

# translate to Secured OTA RFM
secured = self.ota_dialect.encode_cmd(self.ota_keyset, self.tar, self.spi, apdu=apdu)

To view, visit change 42184. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2540472a50b7a49b5a67d088cbdd4a2228eef8f4
Gerrit-Change-Number: 42184
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>