Attention is currently required from: neels, laforge, pespin, lynxis lazus.
Patch set 9:Code-Review -1
View Change
1 comment:
File src/hlr_vty.c:
Patch Set #9, Line 252: info->apn_enc = (uint8_t *) talloc_strdup(g_hlr, apn_name);
This is actually wrong since you simply copy the profile info over in the GSUP message.
osmo_gsup_configure_wildcard_apn() calls osmo_apn_from_str() which encodes the APN and prefixed the length in the beginning (in addition to apn_enc_len).
To view, visit change 32512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f
Gerrit-Change-Number: 32512
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Mon, 22 May 2023 15:05:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment