Attention is currently required from: laforge, neels.

View Change

1 comment:

• File src/osmo-hnbgw/nft_kpi.c:

  • Patch Set #6, Line 86: static __thread struct nft_thread *g_nft_thread = NULL;

    > Simply have one var per thread, even better when you split stuff into different files. […]

    Not exactly imho. __thread is useful when you have N (tons of, unknown) threads spawned which do generic work and use generic code.

    This is not really the case here. You have a well known number of threads (2), each having its own specific purpose and hence context. So it's totally fine having 2 global variables instead of having to use TLS every time each of the threads need to access its context.

To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.