Attention is currently required from: laforge, dexter.

View Change

1 comment:

• File pySim/cards.py:

  • Patch Set #6, Line 36: def __init__(self, scc: LinkBase):

    I wonder if the constructor might also need an annotation for the returned type (-> None)?

    PEP-0484 says we should ("ought"), but it's not strictly necessary, see: https://stackoverflow.com/a/73334605/10668583. Personally I always omit `-> None` in constructors.

To view, visit change 33692. To unsubscribe, or for help writing mail filters, visit settings.