Attention is currently required from: arehbein, fixeria.

View Change

3 comments:

• File include/osmocom/bsc/gsm_data.h:

  • Patch Set #13, Line 50: /* Requirements: We want ny1 to be as low as possible, while respecting T3105 * ny1 > T3124 + delta

    isn't it named "Ny1" in the specs? better use same formatting so that people grepping in the code fins it easily, specially since it's a short name.

  • Patch Set #13, Line 52: #define GSM_NY1_DEFAULT (unsigned long)((GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/GSM_T3105_DEFAULT + 1)

    I see no reason to use the case here. At least better add an extra parenthesis surrounding the whole expression in that case, not sure if there can be unintended problems with the cast if some more stuff is used.

• File tests/nanobts_omlattr/nanobts_omlattr_test.c:

  • Patch Set #13, Line 130: { .T = -3105, .default_val = GSM_NY1_DEFAULT, .val = GSM_NY1_DEFAULT, .min_val = 0, .max_val = UINT8_MAX, .unit = OSMO_TDEF_CUSTOM,

    we usually put negative ones at the end

To view, visit change 30539. To unsubscribe, or for help writing mail filters, visit settings.