Attention is currently required from: jolly, laforge.

Patch set 5:Code-Review -1

View Change

2 comments:

• File src/core/osmo_io.c:

  • Patch Set #5, Line 338: pending = iofd_msgb_alloc2(iofd, msgb_length(iofd->pending) + msgb_length(msg));

    AFAICT this is not fullfilling the requirement that:

        (msgb_length(iofd->pending) + msgb_length(msg)) >= iofd->msgb_alloc.size)
        
    What I meant: msgb_length(iofd->pending) + msgb_length(msg) may be lower than iofd->msgb_alloc.size, which means user will end up with a msgb smaller than expected.

• File src/core/osmo_io_internal.h:

  • Patch Set #5, Line 156: struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t extra);

    this pnew param is named "size" now in the .c file.

To view, visit change 40584. To unsubscribe, or for help writing mail filters, visit settings.