Attention is currently required from: osmith, Hoernchen, neels, pespin, fixeria, daniel.
6 comments:
File src/osmo_io.c:
unsigned int size, unsigned int headroom,
int fd
I guess we could even have defaults for msgb size/headroom and have osmo_iofd_set_alloc_info() avail […]
yes, we could go for that.
Patch Set #3, Line 414: talloc_free(iofd);
The close callback return value indicates whether the free() should be deferred or not, it does not […]
I think Pau's comment was related to the ops.close == NULL case, where you don't free the iofd at all. So I guess talloc_free should be called if (close == NULL || (close && close(iofd))
File src/osmo_io_internal.h:
Patch Set #3, Line 87: // TODO: SCTP_*
I wanted to keep this patch as-is and add sctp support in a separate one. […]
Ack
File src/osmo_io_poll.c:
In socket.c it's called what in the callback, when in the ofd and flags in the internal code. […]
Ack
Patch Set #3, Line 71: rc = write(ofd->fd, msgb_data(msg), msgb_length(msg));
There is no iofd->flags, did you mean msghdr->flags? […]
the normal "read/write" case might be worth a dedicated function as we don't need a serialized msgheader heap allocation for those, right?
Patch Set #3, Line 104: socklen_t addrlen = sizeof(struct sockaddr);
I'd use sizeof(saddr) since that most accurately describes the size recvfrom is allowed to write to.
Ack
To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.