Attention is currently required from: pespin.
Patch set 1:Code-Review +2
1 comment:
Patchset:
That's precisely the point of the asserts, to describe and check that "guaranteed" situation, so tha […]
Yes, I agree with the concept in general. But on the other hand we should not put assert()s everywhere to address every possible failure vector. In this context it's hard to imagine why would somebody change bts_model_l1sap_down() to call this function on receipt of a different prim type, given that it's clear from the function name what kind of the input it expects...
To view, visit change 27720. To unsubscribe, or for help writing mail filters, visit settings.