Attention is currently required from: fixeria.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    So the linter suggests the following: […]

    I guess you could use the do - while loop, and add a semicolon at the end for compatibility:

      #define OSMO_ASSERT(exp) \
      do { \
      	if (!OSMO_LIKELY(exp)) { \
      		osmo_panic("Assert failed %s %s:%d\n", #exp, __FILE__, __LINE__); \
      	} \
      } while (0);

    IMHO this check is really useful in other cases (not here, because the whole macro is inside an if, thus it shouldn't lead to if-else logic defects as described here https://stackoverflow.com/a/9496007).

To view, visit change 27047. To unsubscribe, or for help writing mail filters, visit settings.