Attention is currently required from: fixeria, nt2mku.

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a.

    cosmetic: the usual line length limit for COMMIT_MSG is 72 chars, so please add line break(s).

    Done

• File tests/gsm0408/gsm0408_test.err:

  • Patch Set #7, Line 4:

    @fixeria I see you added a test that expects 3a to be omitted.

    Is this 3a omission according to 3GPP specs? -- if yes, disregard my other comments, but take care to check whether all the osmo-msc tests still pass with this.

    Or is it a workaround for a specific weird device? -- if yes, then let's make the behavior optional, like in my comments.

To view, visit change 36784. To unsubscribe, or for help writing mail filters, visit settings.