Attention is currently required from: daniel, laforge, pespin.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);

    I agree, it probably make sense to […]

    I have restored pre-patch functionality for the sink in this patch and added https://gerrit.osmocom.org/c/libosmocore/+/34881 to simplify it.

    It's WIP, because from what I could tell, the only project currently using a sink is Osmocom-BB and that is running its own version of libosmocore anyways so I'm not sure how to best test this quickly.
    I could probably add a sink to osmo-mgw locally, and then manually send random packets to the socket to see if the behavior changes (?)

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.