pespin submitted this change.

View Change

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve

cosmetic: Improve documentation with spec references about several parameters

Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934
---
M src/osmo-bsc/bts_vty.c
M src/osmo-bsc/system_information.c
2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index f18b6c7..b2b1247 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -1315,6 +1315,7 @@
 	return CMD_SUCCESS;
 }
 
+/* MS_TXPWR_MAX_CCH, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_ms_max_power,
 	      cfg_bts_ms_max_power_cmd,
 	      X(BSC_VTY_ATTR_NEW_LCHAN),
@@ -1333,6 +1334,7 @@
 
 #define CELL_STR "Cell Parameters\n"
 
+/* CELL_RESELECT_HYSTERESIS, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_cell_resel_hyst,
 	      cfg_bts_cell_resel_hyst_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1348,6 +1350,7 @@
 	return CMD_SUCCESS;
 }
 
+/* RXLEV_ACCESS_MIN, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_rxlev_acc_min,
 	      cfg_bts_rxlev_acc_min_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1364,11 +1367,12 @@
 	return CMD_SUCCESS;
 }
 
+/* CELL_BAR_QUALIFY, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_cell_bar_qualify,
 	      cfg_bts_cell_bar_qualify_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
 	      "cell bar qualify (0|1)",
-	      CELL_STR "Cell Bar Qualify\n" "Cell Bar Qualify\n"
+	      CELL_STR "Cell Bar Qualify (CELL_BAR_QUALIFY)\n" "Cell Bar Qualify (CELL_BAR_QUALIFY)\n"
 	      "Set CBQ to 0\n" "Set CBQ to 1\n")
 {
 	struct gsm_bts *bts = vty->index;
@@ -1379,6 +1383,7 @@
 	return CMD_SUCCESS;
 }
 
+/* CELL_RESELECT_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_cell_resel_ofs,
 	      cfg_bts_cell_resel_ofs_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1395,6 +1400,7 @@
 	return CMD_SUCCESS;
 }
 
+/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_temp_ofs,
 	      cfg_bts_temp_ofs_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1411,6 +1417,7 @@
 	return CMD_SUCCESS;
 }
 
+/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_temp_ofs_inf,
 	      cfg_bts_temp_ofs_inf_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1427,6 +1434,7 @@
 	return CMD_SUCCESS;
 }
 
+/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_penalty_time,
 	      cfg_bts_penalty_time_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
@@ -1443,6 +1451,7 @@
 	return CMD_SUCCESS;
 }
 
+/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */
 DEFUN_USRATTR(cfg_bts_penalty_time_rsvd,
 	      cfg_bts_penalty_time_rsvd_cmd,
 	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c
index cc2e788..b438a49 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -1041,7 +1041,7 @@
 	si_info.early_cm_restrict_3g = !bts->early_classmark_allowed_3g;
 
 	/* SI3 Rest Octets (10.5.2.34), containing
-		CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME
+		CELL_BAR_QUALIFY/CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME
 		Power Offset, 2ter Indicator, Early Classmark Sending,
 		Scheduling if and WHERE, GPRS Indicator, SI13 position */
 	rc = osmo_gsm48_rest_octets_si3_encode(si3->rest_octets, &si_info);

To view, visit change 39837. To unsubscribe, or for help writing mail filters, visit settings.