Attention is currently required from: osmith, fixeria.

View Change

2 comments:

• File src/gprs_ms.c:

  • Patch Set #2, Line 1030: if (tlli != GSM_RESERVED_TMSI)

    For the sake of explicitness, I would print TLLI unconditionally.

    I see no need to print some long value here if it is unknown, we better use avaialble space for printing intersting stuff since there's lots of interesting info to print and the log ends up already quite full. So no, I really prefer not printing stuff which is not relevant. Absence of it already tells you there's none assigned/known.

  • Patch Set #2, Line 1032: PRIu8 "-%" PRIu8

    I suggest prefixing the values with 'G' and 'E', respectively. […]

    I'd like to keep the lines as short as possible so I'd rather avoid adding that.

To view, visit change 29996. To unsubscribe, or for help writing mail filters, visit settings.