Attention is currently required from: fixeria, matanp.

View Change

1 comment:

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i);

    1-In my opinion "rf_states", "channel-load", "rach-access-control-classes" and "neighbor-bts list" k […]

    1- Ok I was unaware of other commands using something other than spaces. I think it makes sense to have them standarized. @laforge feedback from you here would be welcome.

    2- if it's using realloc then I think it's fine enough. THough I agree that if you know the maximum size (not sure where 4009 comes from), then simply allocate that buffer and use OSMO_STRBUF_APPEND.

To view, visit change 32565. To unsubscribe, or for help writing mail filters, visit settings.