Attention is currently required from: neels, laforge.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 12: Use OTC_SELECT
Sorry, I disagree with what you are doing here. […]
In my case, I'm not talking about this specific case. I'm talking about the architectural/global implications of doing this in the long term. It may be only here now, but tomorrow will be there and there, and we end up with a big clutter of things, where people keep adding log lines to OTC_SELECT "because other code is already doing it".
To view, visit change 33169. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id903b8579ded8b908e644808e440d373bcca8da4
Gerrit-Change-Number: 33169
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Tue, 13 Jun 2023 12:23:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment