Attention is currently required from: fixeria, laforge, pespin.

View Change

1 comment:

• File tests/test_construct.py:

  • Patch Set #2, Line 8: DnsAdapter,

    The usual approach in our code would be to simply have two (or more) lines starting with "from osmocom.construct import ...".
    See https://gitea.osmocom.org/osmocom/pyosmocom/src/commit/a5bc2a20f439f2ab309a38bfa6e2cf4266e9c11a/src/osmocom/construct.py#L14 for example, > where we have three lines doing "from construct import ..."

    Changed it to that style, please have another look.

To view, visit change 41384. To unsubscribe, or for help writing mail filters, visit settings.