Attention is currently required from: osmith.

View Change

4 comments:

• File gtp/gsn.c:

  • Patch Set #1, Line 424: int domain = in46a_to_af(listen);

    can we call it family at some point? I had to fiugre out what "domain" meant here.

  • Patch Set #1, Line 446: addr.sin_len = sizeof(struct addr);

    wrong indentation.

  • Patch Set #1, Line 461: if (bind(*fd, &addr, sizeof(addr)) < 0)

    the bind can be deduplicated by moving it below.

• File tests/gtp/Makefile.am:

  • Patch Set #1, Line 25: $(top_builddir)/lib/libmisc.a \

    why is this libmisc needed here now?

To view, visit change 36031. To unsubscribe, or for help writing mail filters, visit settings.