fixeria submitted this change.

View Change

Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified
BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,max,ass_updown}

We used to rely on trxcon sendig dummy RR Measurement Reports and
patching the L1 SACCH Header with the configured MS Power Level
and Timing Advance values. Since recently, the following testcases
started to fail because trxcon does not patch dummy MRs anymore:

* TC_rsl_ms_pwr_dyn_ass_updown,
* TC_rsl_ms_pwr_dyn_max, and
* TC_rsl_ms_pwr_dyn_up.

Do not rely on dummy MRs, send SACCH blocks with the expected
MS Power Level and Timing Advance values from the testsuites.

f_send_meas_rep() internally uses:

* g_pars.l1_pars.ms_power_level, and
* g_pars.l1_pars.ms_actual_ta.

Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad
Related: OS#5635
---
M bts/BTS_Tests.ttcn
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 5cf1900..395059a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2979,6 +2979,8 @@
T2.start;
alt {
[] as_l1_sacch_l1h(l1h) {
+ f_send_meas_rep(ts_MeasurementResults);
+
if (l1h.ms_power_lvl < (pwr_var + 6)) {
repeat;
}
@@ -2998,6 +3000,8 @@
T4.start;
alt {
[] as_l1_sacch_l1h(l1h) {
+ f_send_meas_rep(ts_MeasurementResults);
+
if (l1h.ms_power_lvl > pwr_var) {
repeat;
}
@@ -3040,7 +3044,10 @@
timer T1 := 10.0;
T1.start;
alt {
- [] as_l1_sacch_l1h(l1h) { repeat; }
+ [] as_l1_sacch_l1h(l1h) {
+ f_send_meas_rep(ts_MeasurementResults);
+ repeat;
+ }
[] L1CTL.receive { repeat; }
[] T1.timeout {
if (not isbound(l1h)) {
@@ -3086,7 +3093,10 @@
timer T1 := 9.0 * 1.92 + 1.92;
T1.start;
alt {
- [] as_l1_sacch_l1h(l1h) { repeat; }
+ [] as_l1_sacch_l1h(l1h) {
+ f_send_meas_rep(ts_MeasurementResults);
+ repeat;
+ }
[] L1CTL.receive { repeat; }
[] T1.timeout {
if (not isbound(l1h)) {

To view, visit change 28869. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad
Gerrit-Change-Number: 28869
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged