falconia has uploaded this change for review.

View Change

rtp_stream: drop use of codecs[] in struct mgcp_conn_peer

struct mgcp_conn_peer in libosmo-mgcp-client API used to have a
mandatory codecs[] array for codec specification and an optional
ptmap[] array to be used only when the default payload type needs
to be overridden. But now the codecs[] array is deprecated;
the new way is to use ptmap[] to communicate both codecs and
payload types.

These .codecs[] and .codecs_len members in struct mgcp_conn_peer
have been marked as deprecated (and the new way of using only
ptmap[] became available as API) several release cycles ago,
but osmo-msc kept filling out both arrays, leading to compilation
warnings. Remove this use of deprecated API.

Change-Id: I165be5c00bad3d293db2469ee4bedcbe968afcdc
---
M src/libmsc/rtp_stream.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/78/41678/1
diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c
index eb9ba7e..14014c0 100644
--- a/src/libmsc/rtp_stream.c
+++ b/src/libmsc/rtp_stream.c
@@ -329,13 +329,11 @@
codec->subtype_name);
continue;
}
- verb_info.codecs[i] = m->mgcp;
verb_info.ptmap[i] = (struct ptmap){
.codec = m->mgcp,
.pt = codec->payload_type,
};
i++;
- verb_info.codecs_len = i;
verb_info.ptmap_len = i;
}
rtps->codecs_sent_to_mgw = true;

To view, visit change 41678. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I165be5c00bad3d293db2469ee4bedcbe968afcdc
Gerrit-Change-Number: 41678
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon@freecalypso.org>