neels submitted this change.

View Change

Approvals: Jenkins Builder: Verified neels: Looks good to me, approved
tests/ranap_rab_ass: fix potential NULL pointer dereferences

Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Related: CID#275345
---
M tests/ranap_rab_ass/ranap_rab_ass_test.c
M tests/ranap_rab_ass/ranap_rab_ass_test.ok
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.c b/tests/ranap_rab_ass/ranap_rab_ass_test.c
index 043b16b..f4e7999 100644
--- a/tests/ranap_rab_ass/ranap_rab_ass_test.c
+++ b/tests/ranap_rab_ass/ranap_rab_ass_test.c
@@ -61,7 +61,7 @@
OSMO_ASSERT(rc == 0);

encoded = ranap_rab_ass_req_encode(&message.msg.raB_AssignmentRequestIEs);
- printf("ranap_rab_ass_req_encode %s\n", encoded ? "ok" : "ERROR");
+ OSMO_ASSERT(encoded != NULL);

printf("INPUT: %s\n", osmo_hexdump_nospc(testvec, sizeof(testvec)));
printf("RESULT: %s\n", osmo_hexdump_nospc(encoded->data, encoded->len));
@@ -214,6 +214,7 @@
printf("after: addr=%s, port=%u, rab_id=%u\n", addr_str.ip, addr_str.port, rab_id);

encoded = ranap_rab_ass_req_encode(&message.msg.raB_AssignmentRequestIEs);
+ OSMO_ASSERT(encoded != NULL);
OSMO_ASSERT(encoded->len == sizeof(testvec_expected_out));
OSMO_ASSERT(memcmp(encoded->data, testvec_expected_out, encoded->len) == 0);

diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.ok b/tests/ranap_rab_ass/ranap_rab_ass_test.ok
index 47fb97f..73565af 100644
--- a/tests/ranap_rab_ass/ranap_rab_ass_test.ok
+++ b/tests/ranap_rab_ass/ranap_rab_ass_test.ok
@@ -1,4 +1,3 @@
-ranap_rab_ass_req_encode ok
INPUT: 0000005900000100364052000001003500487822cd80102fa7201a2c0000f44c080a028000514000272028140067400000222814003c40000000503d02000227c03500010a0901a200000000000000000000000000401f760000400100
RESULT: 0000005900000100364052000001003500487822cd80102fa7201a2c0000f44c080a028000514000272028140067400000222814003c40000000503d02000227c03500010a0901a200000000000000000000000000401f760000400100
ranap_rab_ass_resp_encode rc=46

To view, visit change 28837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Gerrit-Change-Number: 28837
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged