Attention is currently required from: fixeria, osmith, pespin.

Patch set 2:Code-Review +2

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    The proposed approach looks acceptable to me, so CR+1 from me. […]

    exactly! =)

    But i think Pau's point is that f_ctrl_get_ratectr_abs() now changes its behavior when given an invalid counter name: from titan setverdict(fail) to val == -1.

    We can add another such on_err arg to f_ctrl_get_ratectr_abs(), but I think we can also do that when any caller needs it, i.e. in a future patch. (I think this will never happen, too, because -1 also trivially causes setverdict(fail) in all common usage.)

    I have 2 CR now, let's resolve.

To view, visit change 37189. To unsubscribe, or for help writing mail filters, visit settings.