Attention is currently required from: fixeria.
View Change
1 comment:
Patchset:
Patch Set #1:
I just find memset(0) looks ugly, and regression tests are allowed to look ugly, API implementations not so much.
That's a matter of taste. I never saw anything wrong with it, and we've had it in our codebase as a standard way of initialization for probably a decade or so. In fact, I still intuitively write code that way. It's explicit, everyone knows without doubt what it does.
To view, visit change 31505. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib16964b16eb04315efc416164ed46c15b5dc7254
Gerrit-Change-Number: 31505
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 08:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: comment