Attention is currently required from: dexter, fixeria.
View Change
1 comment:
Patchset:
Patch Set #5:
one of the problems here is that this code only adds it to the GlobalPlatform SecurityDomain class. I think in reality it might be legal for any application to have its own set of SCP02 keys and hence we should permit the shell commands not just after selecting a security domain.
I guess we can leave it for now and solve that at a later point, when the feature is needed.
To view, visit change 35764. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f3c8f0563f81a941dd55b97c9836e3a6856407
Gerrit-Change-Number: 35764
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Feb 2024 11:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment