Attention is currently required from: laforge, pespin.
2 comments:
Patchset:
Somewhat unrelated, but tests/paging/paging_test.ok is hard to review as it has so many lines. Maybe it makes sense to change the test in another patch so it outputs something less verbose?
File src/osmo-bsc/paging.c:
Patch Set #3, Line 394: to, estimated_to);
I think it's not obvious why in most cases you would have "expires in 5 seconds (estimated 5)". Both times are estimates, but "to" is cut off at 60 seconds.
So maybe log a separate message in case the bound is not hit, which only has the number once?
(And maybe the message could be reworded to make it more clear in case the upper bound is reached? But I don't have a good suggestion so maybe just leave as is.)
To view, visit change 28059. To unsubscribe, or for help writing mail filters, visit settings.