Attention is currently required from: pespin.
Patch set 1:Code-Review +1
5 comments:
Patchset:
I have worked that through, in particular the gen_statem implementation was interesting. Now I know how to implement an FSM in erlang.
File src/gsup_server.erl:
Patch Set #1, Line 53: ues = sets:new()
the other record members have a comment, maybe we should add a comment for member "ues" too? (it probably refers to multiple UEs)
Patch Set #1, Line 119: {reply, error, not_implemented}.
This function is deprecated?
Patch Set #1, Line 283: find_gsups_ue_by_imsi(Imsi, State) ->
("gsups" stands for GSUP-Server I guess.)
File src/ue_fsm.erl:
Patch Set #1, Line 83: {stop, Err, Data}
Maybe a default case would be a good idea? I just mentioning this since
https://www.erlang.org/doc/man/gen_statem.html
mentions:
"Postponing an event corresponds to not matching it in a receive statement, and changing states corresponds to entering a new receive statement."
So if auth_handler:auth_request() returns something different than {ok, _} or {error, _}, maybe {foo, _} for example, then the event would be accidentally postponed?
To view, visit change 35659. To unsubscribe, or for help writing mail filters, visit settings.