laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
gsm: fix invalid check in gsm48_decode_ssversion()

Change-Id: I648a4b052d0ec7af97d513630aa4279884436dda
Fixes: OS#5910
---
M src/gsm/gsm48_ie.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c
index 5eca978..11b7168 100644
--- a/src/gsm/gsm48_ie.c
+++ b/src/gsm/gsm48_ie.c
@@ -825,7 +825,7 @@
{
uint8_t in_len = lv[0];

- if (in_len < 1 || in_len < sizeof(ssv->info))
+ if (in_len < 1 || in_len > sizeof(ssv->info))
return -EINVAL;

memcpy(ssv->info, lv + 1, in_len);

To view, visit change 31369. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I648a4b052d0ec7af97d513630aa4279884436dda
Gerrit-Change-Number: 31369
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged