Attention is currently required from: fixeria, laforge.
View Change
1 comment:
Patchset:
Patch Set #1:
I am saying that for libosmo-abis, bcmtoolbox is not a direct (but indirect or implicit) dependency, pulled by ortp.
If it's in the public header, imho it's not an indirect or implicit dependency, it's explicitly part of the ortp API. Otherwise it would be hidden in private headers or .c files.
This is why I don't think it's a good idea to use API of bcmtoolbox.
Agree.
I am inclined to remove this talloc-to-ortp integration completely
I don't have a strong opinion there, so as you wish.
To view, visit change 35502. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 15:11:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment