Attention is currently required from: pespin, fixeria.
View Change
1 comment:
Patchset:
Patch Set #1:
This patch looks +2 worthy, but I'm missing a motivation in the commit log -- these points are important:
- remind us, where exactly is the vsub->cgi PLMN coming from? (Compl L3 Info? Which IE exactly?)
- in what *valid* situation would the PLMN differ?
- in what way is it an improvement to take vsub->cgi's PLMN?
I expect it all makes sense, but currently am not sure...
To view, visit change 33732. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I421bd63a264db2bf6e1c4a4eea976f389e87b332
Gerrit-Change-Number: 33732
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Aug 2023 02:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment