Attention is currently required from: neels, fixeria, pespin.

View Change

4 comments:

• File src/db.c:

  • Patch Set #4, Line 550: 6

    Another approach to ensure the correct version is printed is the logging might be: […]

    Done

• File src/hlr_vty_subscr.c:

  • Patch Set #4, Line 479: * below for real 3G AKA algorithms. */

    (120 line width)

    I don't think its *mandatory* that we use that line length. We just permit it up to 120? Also, 118 is cutting it really close. Most classic 80-character line-wraps are IMHO done at 72, for example. But I changed it .

  • Patch Set #4, Line 510: *maxlen_opc = MILENAGE_KEY_LEN;

    will there ever be minlen_opc < maxlen_opc?

    we don't know what future 3GPP algorithms come up with. TS 33.102 doesn't state any constraint for OP/OPc value length, only for K/RAND/SQN/AK/AMF/CK/IK/RES.

    For TUAK, TOP[c] is fixed at 32 bytes, for MILENAGE its fixed at 16 bytes.

    It was easy enough to prepare the function for situations where it may not be a fixed single valid length value.

  • Patch Set #4, Line 703: vty_out(vty, "%% Unknown auth algorithm: '%s'%s", "xor", VTY_NEWLINE);

    this change looks non-related?

    indeed. no idea how this happeend. I guess some rebase artefact.

To view, visit change 33098. To unsubscribe, or for help writing mail filters, visit settings.