neels submitted this change.

View Change


Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved
cosmetic: regroup members of hnbgw_context_map

Change the order in the struct definition so that the items for RUA and
for SCCP are grouped together. Tweak comments.

Change-Id: I84424617996d8e1a6814aa122e63454c0666b724
---
M include/osmocom/hnbgw/context_map.h
1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h
index 97e1b09..7bcdf57 100644
--- a/include/osmocom/hnbgw/context_map.h
+++ b/include/osmocom/hnbgw/context_map.h
@@ -28,23 +28,26 @@
struct hnbgw_context_map {
/* entry in the per-CN list of mappings */
struct llist_head cn_list;
- /* entry in the per-HNB list of mappings */
+ /* entry in the per-HNB list of mappings. */
struct llist_head hnb_list;
- /* pointer to HNB */
+
+ /* Pointer to HNB for this map, to transceive RUA. */
struct hnb_context *hnb_ctx;
- /* pointer to CN */
- struct hnbgw_cnlink *cn_link;
- /* RUA contxt ID */
+ /* RUA context ID used in RUA messages to/from the hnb_gw. */
uint32_t rua_ctx_id;
- /* False for CS, true for PS */
- bool is_ps;
- /* SCCP User SAP connection ID */
+
+ /* Pointer to CN, to transceive SCCP. */
+ struct hnbgw_cnlink *cn_link;
+ /* SCCP User SAP connection ID used in SCCP messages to/from the cn_link. */
uint32_t scu_conn_id;
/* Set to true on SCCP Conn Conf, set to false when an OSMO_SCU_PRIM_N_DISCONNECT has been sent for the SCCP
* User SAP conn. Useful to avoid leaking SCCP connections: guarantee that an OSMO_SCU_PRIM_N_DISCONNECT gets
* sent, even when RUA fails to gracefully disconnect. */
bool scu_conn_active;

+ /* False for CS, true for PS */
+ bool is_ps;
+
enum hnbgw_context_map_state state;

/* FSM instance for the MGW, handles the async MGCP communication necessary to intercept CS RAB Assignment and

To view, visit change 31463. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I84424617996d8e1a6814aa122e63454c0666b724
Gerrit-Change-Number: 31463
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: merged